-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Smooth Quad Distortion #4901
Smooth Quad Distortion #4901
Conversation
🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already. And be sure to add yourself to the list of contributors on the readme page! |
Thank you @Vamoss ! The WebGL side looks great but I'm not sure I understand the purpose of adding the detailX and detailY for the 2DRenderer. What was your thinking there? |
Hi, I just restored the Even though I was not sure, I kept the changes in I hope everything is right, let me know if I can do anything else :) Cheers, |
Thank you @Vamoss !! |
Resolves #4288
Changes:
Add detailX and detailY parameters to quad function, so users can smooth the quad distortion, it is very visible with textures as described in this issue #4288
PR Checklist
npm run lint
passes