Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smooth Quad Distortion #4901

Merged
merged 4 commits into from
Dec 24, 2020
Merged

Smooth Quad Distortion #4901

merged 4 commits into from
Dec 24, 2020

Conversation

Vamoss
Copy link

@Vamoss Vamoss commented Nov 16, 2020

Resolves #4288

Changes:
Add detailX and detailY parameters to quad function, so users can smooth the quad distortion, it is very visible with textures as described in this issue #4288

PR Checklist

  • npm run lint passes
  • [Inline documentation] is included / updated
  • [Unit tests] are included / updated

@welcome
Copy link

welcome bot commented Nov 16, 2020

🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already. And be sure to add yourself to the list of contributors on the readme page!

@stalgiag
Copy link
Contributor

Thank you @Vamoss !

The WebGL side looks great but I'm not sure I understand the purpose of adding the detailX and detailY for the 2DRenderer. What was your thinking there?

@lmccart
Copy link
Member

lmccart commented Dec 20, 2020

@Vamoss can you give us some insight into the question of detailX and detailY from @stalgiag above?

@Vamoss
Copy link
Author

Vamoss commented Dec 20, 2020

Hi @stalgiag and @lmccart, super sorry for te delay.

I think @stalgiag is right, there is no poimlnt to have it in 2D mode.
The only advantage of this chance is for the webgl methods.

I can make a new pull request in the next few days to restore the original 2D code.

@Vamoss
Copy link
Author

Vamoss commented Dec 21, 2020

Hi,

I just restored the p5.Renderer2D.js file.

Even though I was not sure, I kept the changes in 2d_primitives.js:
75b8afd#diff-9a3dbc4b3ce17b1abf41b9910db0d839b30179f1c8864f0de0d5ba42e1d73d9dL522

I hope everything is right, let me know if I can do anything else :)

Cheers,
Carlos

@lmccart
Copy link
Member

lmccart commented Dec 23, 2020

thanks @Vamoss this looks great! @stalgiag do you want to merge this one if it looks all good to you?

@stalgiag
Copy link
Contributor

stalgiag commented Dec 24, 2020

Thank you @Vamoss !!

@stalgiag stalgiag merged commit 8741583 into processing:main Dec 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Smooth Quad Distortion
3 participants