Fix inline docs of int(), windowResized() and other event handler functions #4989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already. And be sure to add yourself to the list of contributors on the readme page! |
|
@fal-works are you still interested in working on this? Is this PR ready to be submitted for merge? |
|
I'm sorry I left this for a while! |
remove description about "return false" remove @param, @return tags (see processing#4988)
fal-works
force-pushed
the
fix/inline-docs
branch
from
de6fbdc
to
766cc9a
Compare
remove @return tags (see processing#4988)
fal-works
force-pushed
the
fix/inline-docs
branch
from
766cc9a
to
485dc36
Compare
|
Now it should be ready. |
1 task
|
@limzykenneth I know you've been tracking this issue, would you like to take a look over and merge if it's ready? this all looks good to me. |
|
Looks good, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4988
Changes:
Following improvements in the inline docs.
int(): add missing@param [radix]windowResized(),keyPressed()and other keyboard-related functions: add missing@param [event]EDIT: Following changes have been reverted (see #4988).
windowResized(): add description aboutreturn falsewindowResized()and other keyboard/mouse/touch-related functions: add missing@returnPR Checklist
npm run lintpasses