-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor corrections regarding of the text function. #5885
Minor corrections regarding of the text function. #5885
Conversation
there are two problems: 1. If you specify CENTER or BOTTOM for the second argument of textAlign without the 4th and 5th arguments of the text function, some lines will disappear. 2. If CENTER is specified for rectMode, some lines may disappear when box is set by the text function. These fixes are meant to resolve these issues.
🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already. And be sure to add yourself to the list of contributors on the readme page! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very good to me. A bit unusual perhaps to put 2 statements on one line (as in 270), but it seems to pass the linter, so all good
@raclim looks good to merge - 2 fixes to live bugs with text-alignment |
I'm sorry, it would have been better to split it into two lines...is it okay to leave it as is? |
Perhaps update the PR -- just for practice :) |
two statements on line 270 split to two lines.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great
thank you very much for advice! ('ω') |
thanks for the fix! |
Thank you @inaridarkfox4231 and @dhowe ✨! |
there are two problems:
These fixes are meant to resolve these issues.
Resolves: #5880
Changes:
sampleCode for problem 1
left: before change. right: after change.
Screenshots of the change:
sampleCode for problem 2
left: before change. right: after change.
Screenshots of the change:
PR Checklist