Match line drawing orientation to primitive face #5906
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Line drawing in p5.js is done by creating a rectangle with both vertices offset slightly in the direction perpendicular to the line.
In doing so, the orientation of the triangles that make it up is the opposite of the orientation of the faces of primitives (sphere, box, and so on).
This orientation can be matched by reversing the direction of the normals used to shift the vertices in the shader.
Resolves #5877
Changes:
here: src/webgl/shaders/line.vert
Reverses the direction of vertices that are displaced when drawing lines.
This ensures that culling the FRONT to draw only the front face does not cause the lines to disappear.
Screenshots of the change:
sampleCode
left: before, right: after
PR Checklist