Support beginShape(TESS) for faces that don't face the camera #5914
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5913
Previously, all vertices sent to libtess were assumed to be on the XY plane. Libtess can fit a plane to the vertices and use its normal for tesselation, if we tell it the plane's normal is (0,0,0). Presumably this is a little bit slower than not having to do that step, so rather than doing that all the time, I first check if all the vertices have the same z value (likely the most common use case) and tell libtess to use (0,0,1) as the normal if so. Otherwise, it calculates its own normal to use.
Screenshots of the change:
Before: (faces perpendicular to the initial camera turn into holes)
After:
Live: https://editor.p5js.org/davepagurek/sketches/X8o0LFCGd
PR Checklist
npm run lint
passes