Resolves Issue#5958 3D orbitControl allowing +-90 degrees not enough. #6012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@davepagurek Kindly review this. |
davepagurek
approved these changes
Feb 12, 2023
src/webgl/p5.Camera.js
Outdated
| camPhi += dPhi; | ||
| camRadius += dRadius; | ||
| // add change according to the direction of this.upY | ||
| let directionflag = this.upY > 0 ? 1 : -1; |
There was a problem hiding this comment.
Maybe we can name this variable newUpY since that's what it will end up getting used for?
And then the comment about changing according to the direction of this.upY would maybe then be better placed at the if statement where we flip it, with a small explanation of why we have to flip it (something about orbiting to the other side and now being upside-down.)
src/webgl/p5.Camera.js
Outdated
| let directionflag = this.upY > 0 ? 1 : -1; | ||
| camTheta += directionflag*dTheta; | ||
| camPhi += directionflag*dPhi; | ||
| if (camPhi <= 0 || camPhi>=Math.PI) { |
There was a problem hiding this comment.
Super minor, but on this line and the ones above, can we add spaces around the operators so they match the style of the rest of the file?
|
@davepagurek I made all the changes. Kindly review it now. |
davepagurek
approved these changes
Feb 13, 2023
Thanks, wouldn't have been possible without your tips :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5958
Changes:
camPhiwas bound in the range[0,pi]andupYwas only1,directionflagis added to change the direction ofupYof thecameraobject,camPhigets increment with respect to the direction ofupYcamPhican rotate 360 deg and continue rotating in any direction,camThetais modified by multiplying the sign ofdirectionflagto the increment/decrementdirectionflagused to determine theupYproperty of thecameraobjectcamPhiresulted in a need of new testsPR Checklist
npm testnpm run buildpassesnpm run lintpasses