Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removed .prettierrc file #6044

Merged
merged 1 commit into from
Mar 3, 2023
Merged

removed .prettierrc file #6044

merged 1 commit into from
Mar 3, 2023

Conversation

aditya-shrivastavv
Copy link
Contributor

@aditya-shrivastavv aditya-shrivastavv commented Mar 3, 2023 •
edited
Loading

Changes:

since prettier dependency was removed from the project then their is no use of .prettierrc file, that should be removed. this thing is already discussed with @limzykenneth on issue #6038

Impact:

  1. no impact other files or anything.
  2. will be helpful to all the contributors who have vscode prettier extension installed, after the file will be removed the extension will not get automatically activated thus no unnecessary style related changes will take place. I was facing this problem so I had to disable my extension manually.

@limzykenneth limzykenneth merged commit d011f8a into processing:main Mar 3, 2023
@limzykenneth
Copy link
Member

Looks good. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aditya-shrivastavv @limzykenneth