changed mousePressed reference description issue#6045 and variable name of example #6059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@limzykenneth can you please review this pr |
limzykenneth
reviewed
Mar 9, 2023
src/events/mouse.js
Outdated
Comment on lines
617
to
627
| * let color_value = 0; | ||
| * function draw() { | ||
| * fill(value); | ||
| * fill(color_value); | ||
| * rect(25, 25, 50, 50); | ||
| * describe('black 50-by-50 rect turns white with mouse click/press.'); | ||
| * } | ||
| * function mousePressed() { | ||
| * if (value === 0) { | ||
| * value = 255; | ||
| * color_value = 255; | ||
| * } else { | ||
| * value = 0; | ||
| * color_value = 0; |
There was a problem hiding this comment.
Instead of color_value can we use colorValue? Just to keep consistent code style.
|
I have made the necessary changes @limzykenneth |
|
@limzykenneth I have made the necessary changes. Can you merge the pr |
|
Looks good. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #6045
Changes:
Screenshots of the change:
