Improve zooming behavior with orbitControl() #6105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set the sensitivityZ default to 1 and prepare a separate scale factor for zooming. Also change the spec so that the scale changes when _mouseWheelDeltaY changes.
Instead of using addition and subtraction to change distances, logarithms and multiplications are used to change distances. This allows you to achieve the same operability regardless of scale. In addition, we will use near and far clips for distance validation. Because the number 0.1 doesn't make sense depending on the scale.
Fixed unit test because _orbit() has different result when 3rd argument is not 0.
|
It shows how the scaling behavior is improved by applying the patch. 2023-04-15.01-47-20_1.mp4 |
davepagurek
approved these changes
Apr 18, 2023
|
thanks very much for merge! ('ω') |
|
Thanks @inaridarkfox4231 and @davepagurek 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Currently, scaling with webgl's orbitControl() results in jerky behavior.
This is because the judgment method is inappropriate. This is because the change in WheelDeltaY is detected when only the change in WheelY should be detected.
But the problem doesn't stop there. In spite of the fact that behavior that does not depend on the scale is required, the change in the distance from the gaze point is executed by addition and subtraction.
This pull request is to fix these issues.
Resolves #6104
Changes:
First, set sensitivityZ to 1 and prepare a separate scale for zooming.
The decision should be made using the change in WheelY instead of the change in WheelDeltaY.
Furthermore, by changing the distance using a logarithm, the behavior is not affected by the size of the scale.
Finally, let's limit the distance using near and far clips. Because 0.1 doesn't make sense for some scales.
Screenshots of the change:
sample code: improve zooming
PR Checklist
npm run lintpasses