Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix lights() to properly specify gray #6128

Merged
merged 3 commits into from
May 2, 2023
Merged

Fix lights() to properly specify gray #6128

merged 3 commits into from
May 2, 2023

Conversation

inaridarkfox4231
Copy link
Contributor

@inaridarkfox4231 inaridarkfox4231 commented May 2, 2023 •
edited
Loading

Lights() did not support changing the color specification method by colorMode(), so I fixed it.

Resolves #6127

Changes:

The way to specify the color was inappropriate, so I fixed it.

Screenshots of the change:

before:

lights_bug1

after:

lights_bug_fix

PR Checklist

@inaridarkfox4231
Allow lights() to properly specify gray
2d4cc9f 
Lights() did not support changing the color specification method by colorMode(), so I fixed it.
@inaridarkfox4231
Eliminate constants as they are no longer needed.
cac88e3 
You no longer need to use constants. I also changed it to single quotes.
@inaridarkfox4231
I added "this" because it was needed.
b07bbad 
I added "this" because it was needed. Sorry.
davepagurek
davepagurek approved these changes May 2, 2023
View reviewed changes
Copy link
Contributor

@davepagurek davepagurek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this, using the rgb() notation is a clever way to address it!

@davepagurek davepagurek merged commit 6ffaded into processing:main May 2, 2023
@inaridarkfox4231
Copy link
Contributor Author

Thanks!!! ('ω')

@inaridarkfox4231 inaridarkfox4231 deleted the lights_bug branch May 2, 2023 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davepagurek davepagurek davepagurek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The problem that lights() is not able to specify gray properly
2 participants
@inaridarkfox4231 @davepagurek