Supporting existing canvas element for createCanvas() and createGraphics() #6229
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4564
Changes:
createCanvas()
andcreateGraphics()
(includingp5.Graphics
), to both accept passing a 3rd or 4th param (depending on ifrenderer
is given) with an existing html canvas element. WithincreateGraphics()
, it was necessary to both replace thedefaultCanvas0
(created with setup) and tell p5 that the_defaultGraphicsCreated
is false to re-initiate the renderer. WithcreateGraphics()
, in only required intercepting the creation of a canvas element which would have been applied to the body (or node).createCanvas()
changescreateGraphics()
changesp5.Graphics
changesPR Checklist
npm run lint
passes