-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Addresses #6485 Refactor ellipse drawing logic in p5.Renderer2D.js #6499
Conversation
🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already. And be sure to add yourself to the list of contributors on the readme page! |
@tuminzee Basic manual tests I've done with the fork looks fine to me. Let me know if you are ready for this to be merged or you want to implement roundedRect here as well. |
|
@GregStanton it is taking some time for me finish the other functions, should we merge this one function first, and I will complete the other functions later? |
Looks good. Thanks! |
Addresses #6485
Changes:
Screenshots of the change:
PR Checklist
npm run lint
passes