Stores the width and height values before any adjustments are made, Solves #6581

[diyaayay]

Resolves #6581

Changes:

In this modification, I added originalWidth and originalHeight variables to store the width and height values before any adjustments are made. Later in the function, when setting the canvas width and height, I use these original values to update the canvas dimensions. This prevents the issue where the width and height are evaluated as 0 when the element is hidden. The snippet works just fine after the change.

Snippet:

let movie;

function preload() {
	// my video is 640 x 360
	movie = createVideo("flyboard.mp4");
    movie.volume(0);
}

function setup() {
	createCanvas(640, 360);
	pixelDensity(1);
  
	movie.play();
    // Commenting this out makes it work
	movie.hide();
}

function draw() {
	background(220);
    // Commenting this out makes it work
    // (or moving it to setup it seems)
    movie.size(width, height);
    debugger
	image(movie, 0, 0);
}

PR Checklist

• npm run lint passes
• Inline documentation is included / updated
• Unit tests are included / updated

[davepagurek]

Thanks for taking this on, this looks like the right approach! I just have a few questions on the implementation.

[davepagurek]

It looks like we don't set this.width or this.height any more here, was that on purpose?

[diyaayay]

I looked into my approach again and tried changing it to:
this.elt.width = aW;
this.elt.height = aH;

this._pInst._setProperty('width', aW);
this._pInst._setProperty('height', aH);

still doesn't work though, I'm kind of stuck now.

[davepagurek]

Do you need to also set this.width = aW and this.height = aH?

[davepagurek]

Is there a reason for having originalWidth/Height as separate variables, or can we simplify this a bit and just use aW and aH here?

[diyaayay]

Ah yes! I realised it later that aW and aH can be used instead of originalWidth/Height.

[davepagurek]

This might be resetting the width/height to null here, since in this branch, nothing has assigned styleWidth and styleHeight yet.

[davepagurek]

I think this is setting the width/height to null in some cases. I think we can probably just use aW and aH instead of styleHeight since that is defined everywhere

[davepagurek]

I suspect that's the cause of the error I get when trying it out: https://editor.p5js.org/davepagurek/sketches/UX8Yk9fnr

[diyaayay]

@davepagurek I have made changes by removing styleWidth and styleHeight due to the error, opting to use aW and aH instead. While finding the solutions, I came across two potential solutions. The first involves making minor adjustments in the sketch.js file, which isn't the preferred route. The second option is to modify the size function which is what I've been doing. However, I am unsure if I am on the right track with the latter. Am I?

[davepagurek]

I updated the build in the p5 editor link and it seems to work now, thanks for making the changes!