Fix rotation properties being in degrees irrespective of angleMode #6589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SlightlyEpic
changed the title
src/events/acceleration.js
Outdated
Comment on lines
622
to
629
|
|
||
| let multiplier = 1; | ||
| if (this._angleMode === constants.RADIANS) { | ||
| multiplier = constants.PI / 180.0; | ||
| } | ||
| this._setProperty('rotationX', e.beta); | ||
| this._setProperty('rotationY', e.gamma); | ||
| this._setProperty('rotationZ', e.alpha); | ||
| this._setProperty('rotationX', e.beta * multiplier); | ||
| this._setProperty('rotationY', e.gamma * multiplier); | ||
| this._setProperty('rotationZ', e.alpha * multiplier); |
There was a problem hiding this comment.
There is an internal method to convert angles, can you see if you can use that to simplify the implementation instead? https://github.com/processing/p5.js/blob/main/src/math/trigonometry.js#L437
|
Ive added a new internal method, similar to the one you pointed out which converts from degrees to the current angle mode unit (since that one was missing and was needed here). |
|
Looks good. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #6565
Changes:
Fixing the incorrectly lowercased reference to
constants.RADIANSatp5.js/src/events/acceleration.js
Line 622 in 773eb0d
This was also casuing rotation and pRotation properties being in degrees irrespective of the
_angleMode.Changes to
_handleMotionfunction were made to make it work with both degree and radian values.Changes in unit tests related to rotation were made as they expected degree values despite the default mode being radian.
The
angleModemethod in math/trigonometry.js was also changed to update pRotation properties when the mode is changed, this is needed because otherwise the units of rotation and pRotation could end up different, which may cause thedeviceTurnedevent to fire incorrectly.PR Checklist
npm run lintpasses