Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Web Accessibility output not tracking background color changes #6619

Merged
merged 1 commit into from
Dec 16, 2023

Conversation

limzykenneth
Copy link
Member

Resolves #6610

Changes:

The text in textOutput and gridOutput previously only updates when there are changes on the canvas relating to shapes but it won't update if the background color changes while the shapes on the canvas stays the same, resulting in potentially incorrect background color being reported.

This fix adds an additional property to the web accessibility ingredients object that keep tracks of background color changes pBackground plus a check that will re-render the background color when necessary.

PR Checklist

@limzykenneth limzykenneth merged commit 7a36657 into processing:main Dec 16, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

textOutput() and gridOutput() seems to always label a canvas as white regardless of actual background color
2 participants