Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update default values in ortho() docs, use default args in example #6758

Merged
merged 2 commits into from
Jan 26, 2024

Conversation

davepagurek
Copy link
Contributor

@davepagurek davepagurek commented Jan 21, 2024

Resolves #6755

Changes

  • Updates the documentation to mention that the default far value adds 800
  • Removes the args from ortho in the example:
    • Its default far value wasn't suitable when copy-and-pasted into a larger sketch
    • Its y values were flipped vertically, also probably unexpected when copy-and-pasting
  • Removes the camera(...) call: with the updated far value, the camera does not need to be placed closer to the objects to make them visible and have them continue to be visible when zooming/rotating a bit with orbitControl

Screenshots of the change

Before:
image

After:
image

PR Checklist

@davepagurek
Copy link
Contributor Author

@diyaayay since you updated this example last, let me know if you think these changes make sense to you!

@diyaayay
Copy link
Contributor

@davepagurek Yes, I think these work well now. I should have updated the documentation while adding 800 to the default far value.
Thanks for looking into this.

@davepagurek davepagurek merged commit 3d45ce9 into main Jan 26, 2024
4 checks passed
@davepagurek davepagurek deleted the fix/ortho-example branch January 26, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ortho() rendering blank canvas
2 participants