Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[p5.js - es] Translation of contributor_guidelines.md #6876

Merged
merged 17 commits into from
Mar 19, 2024

Conversation

dianamgalindo
Copy link
Contributor

Changes:

Translation of Contributor Guidelines into Spanish. This translation is ongoing and requires revision. The content that has been translated so far is:

  • Introduction
  • Table of Contents
  • All about issues

Copy link

welcome bot commented Mar 16, 2024

🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already. And be sure to add yourself to the list of contributors on the readme page!

Copy link

@holomorfo holomorfo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hola Diana, muchas gracias por tu traducción y enviarlo antes del tiempo solicitado, esto nos ayuda a tener tiempo de corregir cualquier cosa que sea necesaria. Te adjunto algunas correcciones y un par de sugerencias que dejo a tu consideración.
CC: @Guirdo

contributor_docs/es/contributor_guidelines.md Outdated Show resolved Hide resolved
contributor_docs/es/contributor_guidelines.md Outdated Show resolved Hide resolved
contributor_docs/es/contributor_guidelines.md Outdated Show resolved Hide resolved
contributor_docs/es/contributor_guidelines.md Outdated Show resolved Hide resolved
contributor_docs/es/contributor_guidelines.md Outdated Show resolved Hide resolved
contributor_docs/es/contributor_guidelines.md Show resolved Hide resolved
contributor_docs/es/contributor_guidelines.md Outdated Show resolved Hide resolved
contributor_docs/es/contributor_guidelines.md Outdated Show resolved Hide resolved
@Guirdo Guirdo self-assigned this Mar 17, 2024
@Guirdo
Copy link
Contributor

Guirdo commented Mar 17, 2024

Muchas gracias Diana! Estos fueron mis comentarios y sugerencias hasta el momento

@Qianqianye Qianqianye added the Translation Translation of p5.js documentation label Mar 18, 2024
@dianamgalindo dianamgalindo changed the title Spanish translation of contributor_guidelines.md [p5.js - es] Translation of contributor_guidelines.md Mar 18, 2024
Copy link

@holomorfo holomorfo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

El texto me parece correcto, solo no me están funcionando los enlaces de la tabla de contenidos, por favor verifica que funcionen una vez más y si hay algo que corregir.
CC: @Guirdo

@dianamgalindo
Copy link
Contributor Author

@holomorfo @Guirdo He revisado algunos de los links que se encuentran dentro de la documentación. Podrían por favor confirmar el link correcto para lo siguiente (algunos de estos links guian al lector a documentación que están en inglés):

Gracias!

@Guirdo
Copy link
Contributor

Guirdo commented Mar 19, 2024

Solo sería actualizar:

@dianamgalindo
Copy link
Contributor Author

@Guirdo @holomorfo creo que el documento está listo para una última revisión :).

Copy link
Contributor

@Guirdo Guirdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Muchas gracias, Diana! Apruebo tus cambios 💯

@Guirdo
Copy link
Contributor

Guirdo commented Mar 19, 2024

Hi @Qianqianye and @limzykenneth ! This PR is ready!

@Qianqianye Qianqianye merged commit c39634b into processing:main Mar 19, 2024
2 checks passed
@Qianqianye
Copy link
Contributor

Looks great, thanks @dianamgalindo @holomorfo @Guirdo 💗
@all-contributors please add @dianamgalindo for translation

Copy link
Contributor

@Qianqianye

I've put up a pull request to add @dianamgalindo! 🎉

@dianamgalindo dianamgalindo deleted the es=contributor-translation branch March 20, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Translation Translation of p5.js documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants