Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: [p5.js - zh] Added contributor guidelines part 1 + 2 zh translations #6903

Merged

Conversation

Tmicrd
Copy link
Contributor

@Tmicrd Tmicrd commented Mar 19, 2024

Resolves #[Add issue number here]

Changes:

Updated image url.

Screenshots of the change:

image

PR Checklist

@Qianqianye Qianqianye added the Translation Translation of p5.js documentation label Mar 19, 2024
@unicar9
Copy link

unicar9 commented Mar 19, 2024

Hi @Qianqianye and @limzykenneth this small fix PR can be merged, thanks

@Qianqianye
Copy link
Contributor

Thanks @Tmicrd @sproutleaf @unicar9. We realized that the image link is actually not correct in the original English version of contributor_guidelines.md, so @davepagurek will update the image link later today, and then we will update it in all the translated versions. Sorry about the confusion.

@Qianqianye Qianqianye merged commit dd2b75c into processing:main Mar 21, 2024
2 checks passed
@Qianqianye
Copy link
Contributor

For organizational purpose, I will merge this for now. We will update the image links in all the translated files later.
Thanks @Tmicrd @unicar9 @sproutleaf!
@all-contributors please add @Tmicrd for translation

Copy link
Contributor

@Qianqianye

I couldn't determine any contributions to add, did you specify any contributions?
Please make sure to use valid contribution names.

I've put up a pull request to add @Tmicrd! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Translation Translation of p5.js documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants