Fix vertices with different texture coordinates in imported models getting collapsed #6923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #6921
Changes
Previously, when importing models, p5.Geometry vertices were being reused whenever a vertex position + material gets reused in the OBJ code. However, vertex position + color alone are not all that's included in p5.Geometry vertices: it also includes texture position and normals. By not accounting for this, some vertex texture coordinates were being collapsed, leading to interpolation of textures and normals where there should be a seam.
Screenshots of the change
https://editor.p5js.org/davepagurek/sketches/Y1ui2XK_n
PR Checklist
npm run lintpasses