[p5.js KO] Translate access.md #6951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@designerSejinOH @yinhwa PR 완료 했습니다! |
|
@Orwiss 성훈님 1차리뷰 코멘트 반영해주시면 2차 리뷰 이어서 진행하겠습니다 :) 화팅팅💥💥 @designerSejinOH |
first check
|
@designerSejinOH @yinhwa 1차 리뷰 코멘트 반영 완료 했습니다~!! |
yinhwa
reviewed
Apr 9, 2024
There was a problem hiding this comment.
@Orwiss 성훈님! p5.js 커뮤니티의 가장 중요한 문서를 이렇게 멋지게 번역해주셔서 감사드립니다 ㅎㅎ 2차 리뷰 완료 (4:00-4:40, 총 40분)하였고 코멘트 남겨두었습니다!
다른 기여자님들께서도 이 문서 번역문 한번 읽어보시면 좋을것 같아 멘션드립니다 💜@yunyoungJang @YewonCALLI @ienground @designerSejinOH
second review
|
@yinhwa 2차 리뷰 반영 완료했습니다!! |
|
@Orwiss 성훈님 빠른 작업감사드립니다! 내일 오전 중에 마이너한 문법만 제가 직접 수정후 승인 완료하겠습니다 :) @designerSejinOH |
#접근성에 대한 초점 과 ##접근성의 종류 에서 몇가지 표현만 바꾸어 파이널라이즈합니다! @Orwiss
yinhwa
approved these changes
Apr 10, 2024
There was a problem hiding this comment.
Hi, @Qianqianye @limzykenneth we're ready to merge this PR :) thank you @Orwiss @designerSejinOH !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes: Translate access.md
PR Checklist
npm run lintpasses