Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed parameters for normal() method #6984

Merged
merged 1 commit into from
Apr 22, 2024

Conversation

kaiserarg
Copy link
Contributor

@kaiserarg kaiserarg commented Apr 20, 2024

Resolves #6982

Changes:

It seems that in src\core\shape\vertex.js for the normal() method the documentation was written as @param {Vector} vector and since Vector isn't a native JS class when the FES couldn't use instanceOf to check and typeOf checked the e.g. example let n = createVector(-0.4, -0.4, 0.8); which would return object since Vector is not a native JS class.

A quick and easy fix would be to change @param {Vector} vector to @param {p5.Vector} vector so FES can correctly check the parameter.

Screenshots of the change:

image

PR Checklist

Copy link
Contributor

@davepagurek davepagurek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect FES message for normal()
2 participants