Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use modern alpine #76

Closed
wants to merge 1 commit into from
Closed

Conversation

StoneCypher
Copy link

Your version of alpine is two years out of date and has some security and library problems. This replaces 3.11 with 3.15

I did not independently test this change because I don't actually know how

Your version of alpine is two years out of date and has some security and library problems.  This replaces 3.11 with 3.15

I did not independently test this change because I don't actually know how
@p1bot
Copy link
Collaborator

p1bot commented Dec 22, 2021

Hi @StoneCypher, many thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes.

@p1bot p1bot added the cla-missing Contributor needs to sign Contribution License Agreement label Dec 22, 2021
@StoneCypher
Copy link
Author

Unfortunately, you seem to be running a Contributor License Agreement bot that wants privileges to know things about me and make decisions about my github account. "Act on your behalf" is a wide ranging permission that allows you to create and destroy my resources, read my code, and spend my money.

I hereby give you full rights to the single byte I changed

I would still like to have my PR merged because I would be proud to be a contributor even in a trivial way

Please fix your CLA bot, it's asking for way too much

image

@StoneCypher
Copy link
Author

It's worth noting that the version of Alpine that you're shipping is fully outside of support policy as of more than a month ago

You're shipping a Linux version that does not receive any kind of security notices, it's so obsoleted

@StoneCypher
Copy link
Author

note: with 2+ years of changes, the underlying packages have probably changed significantly, and this probably actually causes some breakage

badlop added a commit to badlop/docker-ejabberd that referenced this pull request Dec 28, 2021
@badlop
Copy link
Member

badlop commented Dec 28, 2021

Hi, thanks for reporting this so outdated version!

However, you forgot to update ecs/Dockerfile

On the other hand, 3.15 was just released, 3.14 is good enough to solve the problems that you mentioned. A benefit of 3.14 is that it's already cached in the github actions image used to test this.

The good news is that, apparently, ejabberd runs correctly on Alpine 3.14 (and 3.15).

So, I've updated it to 3.14 in both Dockerfiles

@StoneCypher
Copy link
Author

well it fixes my bug but now i have to find some other way to scam my way into the contributor grid

that means i have to do actual work 😭

@paulmenzel
Copy link
Contributor

I am unable to build the ejabberd/mix image: #77.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-missing Contributor needs to sign Contribution License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants