-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix parsing of custom matrix using legacy syntax #1118
Draft
klutchell
wants to merge
1
commit into
master
Choose a base branch
from
kyle/custom-matrix
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Website deployed to CF Pages, 👀 preview link https://c4062ad5.flowzone.pages.dev |
klutchell
force-pushed
the
kyle/custom-matrix
branch
3 times, most recently
from
July 16, 2024 17:35
6c8277c
to
bda7801
Compare
klutchell
force-pushed
the
kyle/custom-matrix
branch
from
July 16, 2024 17:56
bda7801
to
c5c8be9
Compare
klutchell
force-pushed
the
kyle/custom-matrix
branch
3 times, most recently
from
July 16, 2024 23:23
0bb8655
to
1bf11d1
Compare
klutchell
changed the title
Do not populate os in custom matrix unless provided
Fix parsing of custom matrix using legacy syntax
Jul 16, 2024
We should remove this additional logic as soon as repositories switch to the new JSON syntax for custom matrix inputs. Change-type: patch Signed-off-by: Kyle Harding <[email protected]>
auto-merge was automatically disabled
July 16, 2024 23:30
Pull request was converted to draft
klutchell
force-pushed
the
kyle/custom-matrix
branch
from
July 16, 2024 23:31
1bf11d1
to
f307417
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should remove this additional logic as soon
as repositories switch to the new JSON syntax
for custom matrix inputs.