This repository has been archived by the owner on Nov 22, 2022. It is now read-only.
Fix: Allow for override of repo using OWNER/REPO #678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using flags/commands that override the repo, but don't supply hostname, we allways fallback to `gitlab.com`. This is a problem for commands like `mr checkout 12 -R OWNER/REPO` that should use API host `self-hosted`, but actually use `gitlab.com`. Now we override default host, from the base repo, if one is found. Environment values still override repo host.
Codecov Report
@@ Coverage Diff @@
## trunk #678 +/- ##
==========================================
- Coverage 59.98% 59.98% -0.01%
==========================================
Files 90 90
Lines 6438 6442 +4
==========================================
+ Hits 3862 3864 +2
- Misses 2213 2214 +1
- Partials 363 364 +1
Continue to review full report at Codecov.
|
profclems
added a commit
that referenced
this pull request
Apr 30, 2021
This allows overriding the default protocol of the hostname if a fully qualified url is provided when using the `GITLAB_HOST` environment variable. For example, if the GITLAB_HOST=http://my.glinstance.org, then the host will be set to my.glinstance.org and the protocol become http, unlike before when the protocol was ignored and only the hostname was considered. This is a follow-up for #678 and #667
profclems
added a commit
to olearycrew/glab
that referenced
this pull request
Jun 12, 2021
This allows overriding the default protocol of the hostname if a fully qualified url is provided when using the `GITLAB_HOST` environment variable. For example, if the GITLAB_HOST=http://my.glinstance.org, then the host will be set to my.glinstance.org and the protocol become http, unlike before when the protocol was ignored and only the hostname was considered. This is a follow-up for profclems#678 and profclems#667
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When using flags/commands that override the repo, but don't supply
hostname, we allways fallback to
gitlab.com. This is a problem forcommands like
mr checkout 12 -R OWNER/REPOthat should use API hostself-hosted, but actually usegitlab.com.Now we override default host, from the base repo, if one is found.
Environment values still override repo host.
Related Issue
Resolves #383
How Has This Been Tested?
Locally tried to checkout mr using
mr checkout 12 -R ONWER/REPO, on self hosted instance and everything worked.Types of changes