This repository has been archived by the owner on Nov 22, 2022. It is now read-only.
feat(commands/api): add a reviewer filter to the mr list command #681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## trunk #681 +/- ##
==========================================
- Coverage 59.98% 59.95% -0.03%
==========================================
Files 90 90
Lines 6442 6450 +8
==========================================
+ Hits 3864 3867 +3
- Misses 2214 2218 +4
- Partials 364 365 +1
Continue to review full report at Codecov.
|
profclems
reviewed
Apr 10, 2021
There was a problem hiding this comment.
Thanks @huegelcesar for working on this!
I will review this later in the day
zemzale
approved these changes
Apr 11, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, it's not possible to filter the merge requests list by its reviewers.
So, this MR adds a new optional parameter (
--reviewer) to themr listcommand to enable filtering merge requests by its reviewers.Note: this implementation uses the same flow of assignee filtering and applies an OR operation between Assignee and Reviewer, so it does not break any previous behavior.
Related Issue
Delivers #680
How Has This Been Tested?
Locally tried to list merge requests for different combinations of parameters, on a self-hosted instance and everything worked. Some tested cases:
mr list --reviewer=@memr list --reviewer=@me,OtherUserNamemr list --reviewer=@me --assignee=OtherUserNameTypes of changes