This repository has been archived by the owner on Nov 22, 2022. It is now read-only.
Fix segfault on ci list #691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For gitlab instances running on versions <= 11, the pipeline list api does not return the `created_at` field causing `glab` to panic. This commit checks if the created_at field is available before using it Reolves #688
profclems
force-pushed
the
fix-segfault-ci-list
branch
from
20bb36c
to
2bade26
Compare
Codecov Report
@@ Coverage Diff @@
## trunk #691 +/- ##
=======================================
Coverage 59.95% 59.95%
=======================================
Files 90 90
Lines 6450 6450
=======================================
Hits 3867 3867
Misses 2218 2218
Partials 365 365 Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For gitlab instances running on versions <= 11, the pipeline list api does not return the
created_atfield causingglabto panic.This commit checks if the created_at field is available before using it
Related Issue
Resolves #688
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes