Skip to content
This repository has been archived by the owner on Nov 22, 2022. It is now read-only.

ci: fix the linter by targeting the pr instead of the pr target #861

Merged
merged 1 commit into from
Oct 6, 2021
Merged

ci: fix the linter by targeting the pr instead of the pr target #861

merged 1 commit into from
Oct 6, 2021

Conversation

pataar
Copy link
Contributor

@pataar pataar commented Oct 4, 2021

Description

The linter was targeting the target branch of a pull request, instead of the pull request itself. This way, lint errors would only occur after merging.

Screenshots:

image
You can see the difference here.

How Has This Been Tested?

By fixing the linting issues in this PR as well.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation
  • Chore (Related to CI or Packaging to platforms)

@pataar
Copy link
Contributor Author

pataar commented Oct 4, 2021

Obviously, the linter on pull_request_target fails. Because the target isn't linted correctly.

@codecov
Copy link

codecov bot commented Oct 4, 2021

Codecov Report

Merging #861 (e76db59) into trunk (3d9f97c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##            trunk     #861   +/-   ##
=======================================
  Coverage   59.31%   59.31%           
=======================================
  Files          93       93           
  Lines        7383     7383           
=======================================
  Hits         4379     4379           
  Misses       2619     2619           
  Partials      385      385           
Impacted Files Coverage Δ
commands/mr/create/mr_create.go 33.24% <ø> (ø)
internal/config/writefile.go 100.00% <ø> (ø)
pkg/execext/lp.go 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d9f97c...e76db59. Read the comment docs.

@pataar pataar changed the title ci: fix the linter by targeting the pull request instead of the target ci: fix the linter by targeting the pr instead of the pr target Oct 4, 2021
@profclems profclems merged commit 4b740a5 into profclems:trunk Oct 6, 2021
@pataar pataar deleted the feature/fix_ci_lint branch October 6, 2021 11:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants