Skip to content
This repository has been archived by the owner on Nov 22, 2022. It is now read-only.

feat(command/ci/retry): Add new command to retry CI jobs #868

Merged
merged 3 commits into from
Oct 7, 2021
Merged

feat(command/ci/retry): Add new command to retry CI jobs #868

merged 3 commits into from
Oct 7, 2021

Conversation

szemek
Copy link
Contributor

@szemek szemek commented Oct 7, 2021

Description

Changes add new command that allows to retry CI jobs by job id

Related Issue

Resolves #702

How Has This Been Tested?

Changes were tested manually.

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation
  • Chore (Related to CI or Packaging to platforms)

@codecov
Copy link

codecov bot commented Oct 7, 2021

Codecov Report

Merging #868 (dc2328b) into trunk (1881c26) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##            trunk     #868   +/-   ##
=======================================
  Coverage   59.31%   59.31%           
=======================================
  Files          93       93           
  Lines        7383     7384    +1     
=======================================
+ Hits         4379     4380    +1     
  Misses       2619     2619           
  Partials      385      385           
Impacted Files Coverage Δ
commands/ci/ci.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1881c26...dc2328b. Read the comment docs.

Copy link
Owner

@profclems profclems left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work on this @szemek !

Just a few fixes. Also I was thinking we could support job names as well and not just the ID

commands/ci/retry/retry.go Show resolved Hide resolved
commands/ci/retry/retry.go Outdated Show resolved Hide resolved
docs/source/ci/retry.rst Outdated Show resolved Hide resolved
commands/ci/retry/retry.go Outdated Show resolved Hide resolved
Copy link
Owner

@profclems profclems left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @szemek!

If you ever get time, you can work on adding support for job names and not just the ID, maybe in a separate PR.

@profclems profclems merged commit f127d7e into profclems:trunk Oct 7, 2021
@szemek szemek deleted the ci-retry branch October 7, 2021 17:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cli way of retrying job
2 participants