Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

commit fixes 'include_directory_wildcard_issue1472' test case. #1513

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Sashan
Copy link
Contributor

@Sashan Sashan commented Aug 19, 2022

it fails with error as follows:

not ok ERROR include_directory_wildcard_issue1472
t/lib/ProFTPD/Tests/Config/Include.pm:865 - include_directory_wildcard_issue1472(ProFTPD::Tests::Config::Include)
RETR test.txt succeeded unexpectedly at t/lib/ProFTPD/Tests/Config/Include.pm line 828.

the error which causes the failure is caused by configuration parser:

2022-08-16 10:14:16,580 ST-ul-cbe proftpd[26930]: warning:
unable to include '/tmp/proftpd-test-26903-test5-YaFmyrhTnM/*/test.conf': No such file or directory

I think we don't want to start chopping of path components out side of loop. If I understand things right we should let the loop below to process entire absolute path here.

it fails with error as follows:

	not ok ERROR include_directory_wildcard_issue1472
	t/lib/ProFTPD/Tests/Config/Include.pm:865 - include_directory_wildcard_issue1472(ProFTPD::Tests::Config::Include)
	RETR test.txt succeeded unexpectedly at t/lib/ProFTPD/Tests/Config/Include.pm line 828.

the error which causes the failure is caused by configuration parser:

	2022-08-16 10:14:16,580 ST-ul-cbe proftpd[26930]: warning:
	unable to include '/tmp/proftpd-test-26903-test5-YaFmyrhTnM/*/test.conf': No such file or directory
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant