-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add the ability to configure Http
values
#31
Conversation
I don't think a trait should be used here. Passing a struct that contains configuration values would be better. Maybe even pass |
I don't know about the inner workings of |
It shouldn't cause problems but |
This new type can wrap |
d121321
to
93022c3
Compare
93022c3
to
bfbd3b9
Compare
OK, implemented a new struct for it then. Please take a look 🙂 I think it's only missing the |
Looks good.
|
Oh, I see. If it's good then that's nice 🙂 I need this feature for a crate of mine so would appreciate if a minor release could be made for it. |
I will work on this tomorrow, probably release |
makes the struct easier to move in the future
this method is added in hyper version 0.14.15
probably leaked through when copy pasting from hyper
This PR adds a new trait to allow the created
Http
to be configured.