Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added getter for the number of workers and default constructor #9

Closed
wants to merge 2 commits into from
Closed

Conversation

giacomodrago
Copy link

Non necessary features, but nice-to-have

@progschj
Copy link
Owner

progschj commented Jan 1, 2014

Still thinking about this. The pool is intentionally minimal and mostly a basis to build more specialized ones. Or at least that was my original intention. I guess querying the size on the other hand is trivial enough that it might be reasonable. The hardware_concurrency thing should probably be max(1, hardware_concurrency). Before I put it on github I actually had that default constructor. The issue was that hardware_concurency is allowed to return 0 (which at the time was exactly what it did on my install). So I figured if the user wants hardware_concurrency as default he can pass it and it's the stdlibs fault if it goes wrong :) as opposed to the thread pools for having a non sane default.

@giacomodrago
Copy link
Author

Thank you, I totally see your point. I'll fix the constructor in my fork. Congratulations for your excellent work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants