Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nrfconnect] Adapt Pigweed Logger to newer Zephyr versions #19713

Merged
merged 1 commit into from
Jun 17, 2022

Conversation

Damian-Nordic
Copy link
Contributor

Problem

nRF Connect lighting-app built with RPC crashes after bumping to the recent NCS version.

Change overview

Initialization of the Pigwed HDLC-based Zephyr logging backend would fail due to usage of deprecated backend API.
Switch to the new API.
Fixes #19679

Testing

Tested that the example boots correctly and prints logs to the console.

Initialization of the Pigwed HDLC-based Zephyr logging
backend would fail due to usage of deprecated backend
API.

Signed-off-by: Damian Krolik <[email protected]>
@github-actions
Copy link

github-actions bot commented Jun 17, 2022

PR #19713: Size comparison from 26d6c54 to 4cd9c45

Increases (2 builds for esp32, nrfconnect)
platform target config section 26d6c54 4cd9c45 change % change
esp32 all-clusters-app c3devkit (read only) 1012632 1012636 4 0.0
.flash.text 1012632 1012636 4 0.0
nrfconnect lighting-app nrf52840dk_nrf52840+rpc text 790300 790332 32 0.0
Decreases (5 builds for k32w, nrfconnect, telink)
platform target config section 26d6c54 4cd9c45 change % change
k32w lock k32w061+release (read/write) 720848 720832 -16 -0.0
.text 643852 643836 -16 -0.0
nrfconnect lighting-app nrf52840dk_nrf52840+rpc (read/write) 1127647 1127535 -112 -0.0
rodata 114376 114232 -144 -0.1
pump-app nrf52840dk_nrf52840 (read/write) 1071191 1071175 -16 -0.0
text 743280 743276 -4 -0.0
telink light-switch-app tlsr9518adk80d (read/write) 789016 789008 -8 -0.0
text 559602 559600 -2 -0.0
lighting-app tlsr9518adk80d (read/write) 808728 808720 -8 -0.0
text 576066 576064 -2 -0.0
Full report (38 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 26d6c54 4cd9c45 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 659531 659531 0 0.0
(read/write) 191332 191332 0 0.0
.bss 73756 73756 0 0.0
.data 3356 3356 0 0.0
.rodata 87083 87083 0 0.0
.text 572136 572136 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 647999 647999 0 0.0
(read/write) 157316 157316 0 0.0
.bss 73044 73044 0 0.0
.data 3356 3356 0 0.0
.rodata 90407 90407 0 0.0
.text 557272 557272 0 0.0
lock-ftd LP_CC2652R7 (read only) 690451 690451 0 0.0
(read/write) 150524 150524 0 0.0
.bss 70756 70756 0 0.0
.data 3280 3280 0 0.0
.rodata 99163 99163 0 0.0
.text 590804 590804 0 0.0
lock-mtd LP_CC2652R7 (read only) 639859 639859 0 0.0
(read/write) 143888 143888 0 0.0
.bss 66492 66492 0 0.0
.data 3280 3280 0 0.0
.rodata 99043 99043 0 0.0
.text 540324 540324 0 0.0
pump-app LP_CC2652R7 (read only) 671403 671403 0 0.0
(read/write) 170460 170460 0 0.0
.bss 70876 70876 0 0.0
.data 3280 3280 0 0.0
.rodata 87259 87259 0 0.0
.text 583660 583660 0 0.0
pump-controller-app LP_CC2652R7 (read only) 662399 662399 0 0.0
(read/write) 179592 179592 0 0.0
.bss 71004 71004 0 0.0
.data 3276 3276 0 0.0
.rodata 85183 85183 0 0.0
.text 576732 576732 0 0.0
shell LP_CC2652R7 (read only) 688946 688946 0 0.0
(read/write) 157412 157412 0 0.0
.bss 76052 76052 0 0.0
.data 3360 3360 0 0.0
.rodata 109658 109658 0 0.0
.text 578976 578976 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 612738 612738 0 0.0
.app_xip_area 469404 469404 0 0.0
.bss 86288 86288 0 0.0
.data 728 728 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 610046 610046 0 0.0
.app_xip_area 466536 466536 0 0.0
.bss 86464 86464 0 0.0
.data 732 732 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 616054 616054 0 0.0
.app_xip_area 473608 473608 0 0.0
.bss 85456 85456 0 0.0
.data 672 672 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 924008 924008 0 0.0
(read/write) 132416 132416 0 0.0
.bss 130336 130336 0 0.0
.data 2080 2080 0 0.0
.text 924000 924000 0 0.0
BRD4161A+rpc (read only) 959712 959712 0 0.0
(read/write) 149296 149296 0 0.0
.bss 147008 147008 0 0.0
.data 2284 2284 0 0.0
.text 959704 959704 0 0.0
BRD4161A+rs911x (read only) 799092 799092 0 0.0
(read/write) 128692 128692 0 0.0
.bss 126604 126604 0 0.0
.data 2088 2088 0 0.0
.text 799084 799084 0 0.0
lock-app BRD4161A+wf200 (read only) 965524 965524 0 0.0
(read/write) 129068 129068 0 0.0
.bss 126980 126980 0 0.0
.data 2088 2088 0 0.0
.text 965516 965516 0 0.0
window-app BRD4161A (read only) 909104 909104 0 0.0
(read/write) 132520 132520 0 0.0
.bss 130408 130408 0 0.0
.data 2108 2108 0 0.0
.text 909096 909096 0 0.0
esp32 all-clusters-app c3devkit (read only) 1012632 1012636 4 0.0
(read/write) 1482898 1482898 0 0.0
.dram0.bss 69392 69392 0 0.0
.dram0.data 14632 14632 0 0.0
.flash.rodata 213440 213440 0 0.0
.flash.text 1012632 1012636 4 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1067171 1067171 0 0.0
(read/write) 485016 485016 0 0.0
.dram0.bss 74912 74912 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 243964 243964 0 0.0
.flash.text 1061787 1061787 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 658876 658876 0 0.0
.bss 68756 68756 0 0.0
.data 1992 1992 0 0.0
.text 582328 582328 0 0.0
lock k32w061+release (read/write) 720848 720832 -16 -0.0
.bss 69196 69196 0 0.0
.data 2000 2000 0 0.0
.text 643852 643836 -16 -0.0
linux chip-tool-no-interactive-ipv6only arm64 (read only) 9881788 9881788 0 0.0
(read/write) 674225 674225 0 0.0
.bss 42641 42641 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 613208 613208 0 0.0
.dynamic 528 528 0 0.0
.got 13416 13416 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 472300 472300 0 0.0
.text 7873060 7873060 0 0.0
thermostat-no-ble arm64 (read only) 2570668 2570668 0 0.0
(read/write) 192193 192193 0 0.0
.bss 99489 99489 0 0.0
.data 1688 1688 0 0.0
.data.rel.ro 82928 82928 0 0.0
.dynamic 528 528 0 0.0
.got 5072 5072 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 163324 163324 0 0.0
.text 2168224 2168224 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2437720 2437720 0 0.0
.bss 208204 208204 0 0.0
.data 5864 5864 0 0.0
.text 1400364 1400364 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1198699 1198699 0 0.0
bss 141598 141598 0 0.0
rodata 155676 155676 0 0.0
text 822504 822504 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1146655 1146655 0 0.0
bss 140850 140850 0 0.0
rodata 132200 132200 0 0.0
text 794724 794724 0 0.0
lighting-app nrf52840dk_nrf52840 (read/write) 1158239 1158239 0 0.0
bss 143177 143177 0 0.0
rodata 122616 122616 0 0.0
text 813588 813588 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 1127647 1127535 -112 -0.0
bss 143622 143622 0 0.0
rodata 114376 114232 -144 -0.1
text 790300 790332 32 0.0
nrf52840dongle_nrf52840 (read/write) 1065383 1065383 0 0.0
bss 150408 150408 0 0.0
rodata 91760 91760 0 0.0
text 742092 742092 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 1061930 1061930 0 0.0
bss 139548 139548 0 0.0
rodata 115024 115024 0 0.0
text 726320 726320 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 1111295 1111295 0 0.0
bss 133125 133125 0 0.0
rodata 139344 139344 0 0.0
text 759948 759948 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 1015158 1015158 0 0.0
bss 129528 129528 0 0.0
rodata 131812 131812 0 0.0
text 672736 672736 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 1071191 1071175 -16 -0.0
bss 133072 133072 0 0.0
rodata 116000 116000 0 0.0
text 743280 743276 -4 -0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 1064343 1064343 0 0.0
bss 132869 132869 0 0.0
rodata 114896 114896 0 0.0
text 737656 737656 0 0.0
p6 all-clusters-app default (read/write) 2553568 2553568 0 0.0
.bss 143384 143384 0 0.0
.data 2776 2776 0 0.0
.text 1511832 1511832 0 0.0
all-clusters-minimal-app default (read/write) 2499416 2499416 0 0.0
.bss 142664 142664 0 0.0
.data 2776 2776 0 0.0
.text 1457680 1457680 0 0.0
light-app default (read/write) 2430160 2430160 0 0.0
.bss 134744 134744 0 0.0
.data 2592 2592 0 0.0
.text 1388424 1388424 0 0.0
lock-app default (read/write) 2450784 2450784 0 0.0
.bss 134568 134568 0 0.0
.data 2600 2600 0 0.0
.text 1409048 1409048 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 789016 789008 -8 -0.0
bss 69892 69892 0 0.0
noinit 40416 40416 0 0.0
text 559602 559600 -2 -0.0
lighting-app tlsr9518adk80d (read/write) 808728 808720 -8 -0.0
bss 70140 70140 0 0.0
noinit 40416 40416 0 0.0
text 576066 576064 -2 -0.0

@andy31415 andy31415 merged commit 7f83fbf into project-chip:master Jun 17, 2022
@Damian-Nordic Damian-Nordic deleted the pigweed-logger branch June 17, 2022 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NRF RPC build is broken
3 participants