Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Silabs] WiFi - fix for 917SoC commissionable data provider #26128

Conversation

silabs-srishylam
Copy link
Contributor

@silabs-srishylam silabs-srishylam commented Apr 17, 2023

Fix for the commissionable data provider

The macro needed for the commissionable data provider is not in common location in .gn file, this causing the issue
Moved the macro to a common location in .gn file

Resolved build failure issue for 917SoC commissionable data provider caused by #26107

@github-actions
Copy link

PR #26128: Size comparison from 3037a8a to c37b6a8

Decreases (1 build for cc32xx)
platform target config section 3037a8a c37b6a8 change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20328411 20328410 -1 -0.0
Full report (1 build for cc32xx)
platform target config section 3037a8a c37b6a8 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 643249 643249 0 0.0
(read/write) 203848 203848 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197248 197248 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 933224 933224 0 0.0
.debug_aranges 87792 87792 0 0.0
.debug_frame 302140 302140 0 0.0
.debug_info 20328411 20328410 -1 -0.0
.debug_line 2687890 2687890 0 0.0
.debug_loc 2838930 2838930 0 0.0
.debug_ranges 288072 288072 0 0.0
.debug_str 3042155 3042155 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 104401 104401 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 377963 377963 0 0.0
.symtab 256976 256976 0 0.0
.text 536728 536728 0 0.0

Copy link
Contributor

@jepenven-silabs jepenven-silabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The return CHIP_NO_ERROR should be move to the now common DeviceDataProvider after a rebase on master

@silabs-srishylam silabs-srishylam force-pushed the bugfix/kwifi_917SoC_commissionable_data branch from c37b6a8 to 992f6f8 Compare April 18, 2023 06:03
@github-actions
Copy link

PR #26128: Size comparison from 19909ce to 992f6f8

Full report (1 build for cc32xx)
platform target config section 19909ce 992f6f8 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 643249 643249 0 0.0
(read/write) 203848 203848 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197248 197248 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 933224 933224 0 0.0
.debug_aranges 87792 87792 0 0.0
.debug_frame 302140 302140 0 0.0
.debug_info 20328411 20328411 0 0.0
.debug_line 2687890 2687890 0 0.0
.debug_loc 2838930 2838930 0 0.0
.debug_ranges 288072 288072 0 0.0
.debug_str 3042155 3042155 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 104401 104401 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 377963 377963 0 0.0
.symtab 256976 256976 0 0.0
.text 536728 536728 0 0.0

@github-actions
Copy link

PR #26128: Size comparison from 19909ce to 3bf2f77

Increases (1 build for cc32xx)
platform target config section 19909ce 3bf2f77 change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20328411 20330830 2419 0.0
.debug_line 2687890 2687904 14 0.0
.debug_loc 2838930 2838960 30 0.0
.debug_str 3042155 3042335 180 0.0
Full report (1 build for cc32xx)
platform target config section 19909ce 3bf2f77 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 643249 643249 0 0.0
(read/write) 203848 203848 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197248 197248 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 933224 933224 0 0.0
.debug_aranges 87792 87792 0 0.0
.debug_frame 302140 302140 0 0.0
.debug_info 20328411 20330830 2419 0.0
.debug_line 2687890 2687904 14 0.0
.debug_loc 2838930 2838960 30 0.0
.debug_ranges 288072 288072 0 0.0
.debug_str 3042155 3042335 180 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 104401 104401 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 377963 377963 0 0.0
.symtab 256976 256976 0 0.0
.text 536728 536728 0 0.0

@jepenven-silabs jepenven-silabs enabled auto-merge (squash) April 18, 2023 15:33
@jepenven-silabs jepenven-silabs merged commit 2bedaf3 into project-chip:master Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants