[SVE] TC-MCORE-FS-1.3: Bump the DUT timeout for newly added device #35740
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with SemanticDiff. Analyzed 1 of 1 files. Overall, the semantic diff is 3% smaller than the GitHub diff.
|
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
axelnxp,
bauerschwan,
bzbarsky-apple,
carol-apple,
cecille,
chapongatien,
chrisdecenzo,
chshu and
chulspro
pullapprove
bot
added
tests
matter-1.4-te2-script-change
saurabhst
approved these changes
Sep 23, 2024
|
PR #35740: Size comparison from 1597be7 to eef4a94 Full report (88 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
arkq
reviewed
Sep 24, 2024
|
@samadDotDev how did you create this PR? It runs double the CI for some reason, and I believe it may be that it uses a main repo branch instead of a fork. Could you confirm? Could you please switch to using forks for development? |
andy31415
reviewed
Oct 3, 2024
andy31415
approved these changes
Oct 3, 2024
tehampson
approved these changes
Oct 3, 2024
|
PR #35740: Size comparison from 2651245 to 1d26d39 Full report (29 builds for cyw30739, linux, nrfconnect, nxp, psoc6, qpg, stm32, tizen)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This timeout is pretty short because right after issuing the
CommissionerControlCluster::ReverseOpenCommissioningWindowcommand, the DUT is expected to discover the newly advertised_matterc._udpservice, resolve its address, establish PASE, install theDUT_FSA's fabric, subscribe (& perform other necessary interactions during onboarding) before making it available as a newly accessible bridged node on theDUT_FSA's aggregator parts list, and some of these operations can take a bit of time.Bumping up to 30s, consistent with a few other FS test cases.
Fixes #35739