-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TC-VALCC-3.1: Allow immediate open of valve #35851
base: master
Are you sure you want to change the base?
TC-VALCC-3.1: Allow immediate open of valve #35851
Conversation
If the valve can be opened before the command is complete or before the next read is done, the test will fail because it expects the transitioning phase to happen. In the spec: When the movement is complete, the device SHALL set the CurrentState attribute to the Open value. ^ this can happen before the end of the command.
Review changes with SemanticDiff. Analyzed 1 of 1 files. Overall, the semantic diff is 33% smaller than the GitHub diff.
|
PR #35851: Size comparison from 9c6c365 to fa83b47 Full report (88 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
current_state_dut = await self.read_valcc_attribute_expect_success(endpoint=endpoint, attribute=attributes.CurrentState) | ||
asserts.assert_true(current_state_dut is not NullValue, "CurrentState is null") | ||
asserts.assert_true(target_state_dut is not NullValue, "TargetState is null") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should these nullability asserts also apply outside of the while? It seems like conditions should always be consistent except we have a retry while current state is transitioning
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe the checks are also done in step 4, it just means we read it twice to get there. Will add a checkmark, up to you if this really needs update or not.
If the valve can be opened before the command is complete or before the next read is done, the test will fail because it expects the transitioning phase to happen.
In the spec:
When the movement is complete, the device SHALL set the CurrentState attribute to the Open value.
^ this can happen before the end of the command.