Endpoint Composition - Adding helper which has a NULL placeholder + tests #1259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulr34
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1259 +/- ##
==========================================
+ Coverage 65.19% 65.21% +0.02%
==========================================
Files 188 188
Lines 19764 19769 +5
Branches 4228 4230 +2
==========================================
+ Hits 12885 12893 +8
+ Misses 6879 6876 -3 ☔ View full report in Codecov by Sentry. |
tecimovic
approved these changes
Feb 6, 2024
| let parentIds = [] | ||
| this.endpoints.forEach((ep) => { | ||
| if (ep.parentEndpointIdentifier == null) { | ||
| parentIds.push('NULL') |
There was a problem hiding this comment.
You are hard-coding C NULL here. Not the biggest evil, but I thought we have this externalized somewhere?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding helper which adds Parent Endpoint ID per Endpoint to an array OR NULL if the Endpoint has no Parent