Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix editing parent endpoints #1263

Merged
merged 6 commits into from
Feb 13, 2024

Conversation

paulr34
Copy link
Collaborator

@paulr34 paulr34 commented Feb 7, 2024

Bug fix:

When user edits Endpoint it must return Endpoint Identifier to the GUI and not the database reference

@codecov-commenter
Copy link

codecov-commenter commented Feb 7, 2024

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

Comparison is base (e9aed75) 65.21% compared to head (455e1f2) 65.19%.

Files Patch % Lines
src-electron/rest/user-data.js 25.00% 6 Missing ⚠️
src-electron/rest/endpoint.js 0.00% 5 Missing ⚠️
src-electron/db/query-config.js 33.33% 2 Missing ⚠️
src/store/zap/actions.js 66.66% 1 Missing ⚠️
src/store/zap/mutations.js 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1263      +/-   ##
==========================================
- Coverage   65.21%   65.19%   -0.03%     
==========================================
  Files         188      188              
  Lines       19769    19785      +16     
  Branches     4230     4230              
==========================================
+ Hits        12893    12899       +6     
- Misses       6876     6886      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src-electron/rest/endpoint.js Outdated Show resolved Hide resolved
@paulr34 paulr34 merged commit 108fb3e into project-chip:master Feb 13, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants