show NULL when nullable and default is null #1336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tecimovic
approved these changes
Jun 12, 2024
| :model-value=" | ||
| props.row.isNullable && | ||
| defaultValueCheck(props.row.id, selectedCluster.id) === null | ||
| ? 'NULL' |
There was a problem hiding this comment.
I am not happy that we hardcode "NULL" here. This is mixing up the C concept of "NULL" with a concept of "nil" from the spec.
What if we're not generating for C, so we don't have "NULL"?
brdandu
reviewed
Jun 12, 2024
| @@ -211,11 +216,6 @@ limitations under the License. | |||
| color="secondary" | |||
| label="Null" | |||
| size="sm" | |||
| :disabled=" | |||
There was a problem hiding this comment.
Why is this change needed?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when default value is null and the attribute isNullable then the defaultValue is NULL not empty