-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/reconfigure the new edpoint card #1354
Merged
tbrkollar
merged 6 commits into
project-chip:master
from
tbrkollar:feature/reconfigure-the-new-edpoint-card
Jul 18, 2024
Merged
Feature/reconfigure the new edpoint card #1354
tbrkollar
merged 6 commits into
project-chip:master
from
tbrkollar:feature/reconfigure-the-new-edpoint-card
Jul 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbrkollar
force-pushed
the
feature/reconfigure-the-new-edpoint-card
branch
from
July 11, 2024 08:13
b450ed3
to
9b5793e
Compare
brdandu
requested changes
Jul 15, 2024
brdandu
requested changes
Jul 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also add cypress tests to cover these changes for future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
with next issue i will create cypress test for this feature.
paulr34
approved these changes
Jul 15, 2024
brdandu
approved these changes
Jul 17, 2024
tbrkollar
force-pushed
the
feature/reconfigure-the-new-edpoint-card
branch
from
July 18, 2024 08:20
c005b15
to
b20e1a8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reconfigure the create new endpoint based on device type
In Matter mode, Remove the Profile ID from device card and new endpoint card.
Remove the option to choose multiple device types with Zigbee in CMP.