Fix fails in gen-zigbee unit tests #1368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanzhouyc
changed the title
paulr34
approved these changes
Jul 25, 2024
|
Mentioning the name of function changed and mentioning its role in these tests might be useful. |
…zigbee unit tests - Fix possible fails in gen-zigbee-x.test.js unit tests due to inconsistent execution order in async functions - Replace .then() with await and replace forEach with for loop in ensurePackagesAndPopulateSessionOptions to ensure proper async flow - Keep using promises in other parts of the function for faster parallel execution
brdandu
approved these changes
Jul 25, 2024
| selectedGenTemplatePackages && | ||
| selectedGenTemplatePackages.length > 0 | ||
| ) { | ||
| for (const gen of selectedGenTemplatePackages) { |
There was a problem hiding this comment.
Minor stuff const genPkgId gives more readability but not a big deal.
There was a problem hiding this comment.
It would be good to break this long function into smaller pieces but that can be done on a later date so do not worry about it now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix possible fails in gen-zigbee-x.test.js unit tests due to inconsistent execution order in async functions
Replace .then() with await and replace forEach with for loop in ensurePackagesAndPopulateSessionOptions to ensure proper async flow
Keep using promises in other parts of the function for faster parallel execution