Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixing issue_1356 #1381

Merged
merged 1 commit into from
Jul 31, 2024
Merged

fixing issue_1356 #1381

merged 1 commit into from
Jul 31, 2024

Conversation

paulr34
Copy link
Collaborator

@paulr34 paulr34 commented Jul 31, 2024

when a nullable string is null, the javascript code should be a string and not an array so the generated code compiles

@paulr34 paulr34 requested a review from tecimovic July 31, 2024 09:28
tecimovic
tecimovic approved these changes Jul 31, 2024
View reviewed changes
Copy link
Collaborator

@tecimovic tecimovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really sure why we had arrays there in the first place. Purely technically, arrays would be nice, but I see that the longTypeDefaultValue doesn't return array either, so I guess this is at least makes it consistently un-nice....

@paulr34 paulr34 merged commit 69b3522 into project-chip:master Jul 31, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tecimovic tecimovic tecimovic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paulr34 @tecimovic