fix: remove wrong condition from ZapConfig #1385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbrkollar
force-pushed
the
fix/logo-is-missing-on-toolbar
branch
from
f59cd21
to
cf1ba5e
Compare
brdandu
requested changes
Aug 2, 2024
src/pages/ZapConfig.vue
Outdated
| (zfp) => zfp.type != dbEnum.packageType.zclXmlStandalone | ||
| ) | ||
| currentZapFileZclPacakges = this.currentZapFilePackages.filter( | ||
| (zfp) => zfp.type == dbEnum.packageType.zclProperties | ||
| ) | ||
|
|
||
| currentZapFileTemplatePacakges = this.currentZapFilePackages.filter( |
There was a problem hiding this comment.
what about currentZapFileZclPacakges.map below
src/pages/ZapConfig.vue
Outdated
| let currentZapFileZclPacakges = [] | ||
| let currentTopLevelZapFilePacakges = [] | ||
| let currentZapFileTemplatePacakges = [] | ||
| console.log(result.data.zapFilePackages) |
| let currentZapFileTemplatePacakges = [] | ||
| console.log(result.data.zapFilePackages) | ||
| let currentZapFileZclPackages = [] | ||
| let currentTopLevelZapFilePackages = [] |
There was a problem hiding this comment.
What about the changes to currentTopLevelZapFilePacakges.length below?
| @@ -688,18 +688,20 @@ export default { | |||
| this.filePath = result.data.filePath | |||
| this.open = result.data.open | |||
| this.currentZapFilePackages = result.data.zapFilePackages | |||
| let currentZapFileZclPacakges = [] | |||
| let currentTopLevelZapFilePacakges = [] | |||
| let currentZapFileTemplatePacakges = [] | |||
There was a problem hiding this comment.
What about currentZapFileTemplatePacakges.map below?
paulr34
approved these changes
Aug 2, 2024
| @@ -716,16 +717,13 @@ export default { | |||
| this.zclPropertiesRow.length == currentZapFileZclPacakges.length || | |||
| this.zclPropertiesRow.length == 1 | |||
| ) { | |||
| // We shortcut this page, if the number of packages in the zap file | |||
| // and the number of packages loaded in the backend are the same. | |||
| if (this.zclGenRow.length == currentZapFileTemplatePacakges.length) { | |||
There was a problem hiding this comment.
This is a typo that's probably breaking everything
src/pages/ZapConfig.vue
Outdated
| @@ -716,16 +717,13 @@ export default { | |||
| this.zclPropertiesRow.length == currentZapFileZclPacakges.length || | |||
There was a problem hiding this comment.
it should be "currentZapFileZclPackages"
tbrkollar
force-pushed
the
fix/logo-is-missing-on-toolbar
branch
from
6bd469f
to
ab6ac00
Compare
brdandu
approved these changes
Aug 5, 2024
| @@ -40,4 +40,11 @@ describe('Check theme functionality', () => { | |||
| cy.rendererApi(rendApi.id.setDarkTheme, 'false') | |||
| cy.get('body').should('have.class', 'body--light') | |||
| }) | |||
| it('Zigbee mode', () => { | |||
There was a problem hiding this comment.
From next time add a description on what the test is testing. Difficult to understand what this might be testing in the first go.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.