Getting rid of unused packages #1388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brdandu
force-pushed
the
improvement/cleanupNPMPackages/ZAPP-1138
branch
3 times, most recently
from
42c4e02
to
e77646c
Compare
brdandu
force-pushed
the
improvement/cleanupNPMPackages/ZAPP-1138
branch
2 times, most recently
from
ad5e439
to
42f5051
Compare
paulr34
approved these changes
Aug 14, 2024
brdandu
force-pushed
the
improvement/cleanupNPMPackages/ZAPP-1138
branch
2 times, most recently
from
14bf9fd
to
bb2f7c5
Compare
- Adding quasar extra package back since npm run build-spa was not working without it - Getting rid of more dev packages which are not needed - Adding quasar extensions for testing and testing e2e-cypress. This is used by the npm run build-spa. It was throwing App Quasar App Extension @quasar/testing is missing... and doing quasar ext add quasar/testing-e2e-cypress and quasar ext add quasar/testing solved it. - Updating the cypress and eslint cypress plugin package - Adding license checker since that is used by npm run lic - Adding quasar extensions for testing and testing e2e-cypress. This is used by the npm run build-spa. It was throwing App Quasar App Extension @quasar/testing is missing... and doing quasar ext add quasar/testing-e2e-cypress and quasar ext add quasar/testing solved it. - Updating the cypress and eslint cypress plugin package - Adding license checker since that is used by npm run lic - No need to import @jest/globals as these are automatically provided by jest globally. - Adding autoprofixer package because it is required in .postcssrc.js - Adding test-utils package because it is required by test/jest/utils/index.js - Adding tough-cookie package which is required by src-script/gen-test-runner.js - Adding 7zip-bin package because it is required by src-script/pack-apack-mac.js - Adding cross-spawn package because it is required by src-script/script-util.js - Adding fs-extra package which is used by src-script/zap-combine-reports.js - Cleaning up the relative paths in src/router/routes.js because the import paths had the wrong relative paths - Adding a node module package dependency test for unused packages in github workflows - Getting rid of webpack-cli, webpack-node-externals - Requiring license-checker module properly in license-check.js such that the npm package dependencies are analyzed correctly by something like npm-check or depcheck - Updating jest-junit which is used to get code coverage - Getting rid of file-loader and devtron packages - Commenting out the depcheck workflow for now - Getting rid of the unused packages caught from depcheck: Unused devDependencies types/bytebuffer types/node-ipc types/sqlite3 types/underscore babel-plugin-istanbul eslint-plugin-cypress eslint-plugin-node eslint-plugin-promise eslint-plugin-quasar - Updating a bunch of packages reported from npm-check - downgrading typescript package upgrade and adding queryString package because npm run build-spa fails without these 2 changes - Reverting the package upgrade to node-ipc - Reverting the changes made to quasar extentions json file - Downgrading the Vue tour package because upgrading it breaks the vue tour - Downgrading some of the packages because they are causing notifications pane to not work properly - Updating sqlite3 and rmeoving the github actions for now - fixing ui.test.js for undefined this.endpointId and component not defined - Reverting the changes to the relative path in the routes - Adding a router for the ui.test.js because the ui tests are not picking up the new router information and therefore throwing a Component not defined error which was happening due to the Vue packages and their dependencies being updated - Downgrading axios since Github CI is runnning into axios issues on matter regen - updating node-gyp and cypress code coverage npm pacakges - JIRA: ZAPP-1138
brdandu
force-pushed
the
improvement/cleanupNPMPackages/ZAPP-1138
branch
from
bb2f7c5
to
acec3cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: ZAPP-1138