Fix support for global types in Python Matter codegen #1394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saurabhst
approved these changes
Aug 8, 2024
tehampson
approved these changes
Aug 13, 2024
andy31415
approved these changes
Aug 13, 2024
brdandu
approved these changes
Aug 13, 2024
paulr34
force-pushed
the
fix-python
branch
2 times, most recently
from
37e401f
to
dc52ea8
Compare
The support for global types was added in commit af33f57. However, it was added only in zapTypeToPythonClusterObjectType(). For proper functionality support in getPythonFieldDefault() is also required.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The support for global types was added in commit af33f57. However, it was added only in
zapTypeToPythonClusterObjectType(). For proper functionality support ingetPythonFieldDefault()is also required.