Issue 1397 #1398
Merged
Issue 1397 #1398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulr34
requested review from
tecimovic,
brdandu,
ethanzhouyc,
dhchandw and
tbrkollar
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1398 +/- ##
==========================================
+ Coverage 66.00% 66.23% +0.22%
==========================================
Files 194 191 -3
Lines 20528 20640 +112
Branches 4455 4528 +73
==========================================
+ Hits 13550 13670 +120
+ Misses 6978 6970 -8 ☔ View full report in Codecov by Sentry. |
brdandu
reviewed
Aug 12, 2024
brdandu
reviewed
Aug 12, 2024
brdandu
requested changes
Aug 13, 2024
ethanzhouyc
approved these changes
Aug 13, 2024
brdandu
approved these changes
Aug 13, 2024
| let queryParams = [code, ...packageIds, code, ...packageIds] | ||
|
|
||
| // Since packageIds is now always an array, adjust the query and parameters accordingly | ||
| const placeholders = packageIds.map(() => '?').join(', ') |
There was a problem hiding this comment.
You can do the standard:
IN (${dbApi.toInClause(packageIds)})
…g a Number to be passed as an alternative
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1397
This pull request retrieves the cluster/attribute pairs for all attributeAccessInterface attributes, including those of the list type.
Background: The ATTRIBUTE table designates CLUSTER_REF as null for global attributes.
To incorporate cluster/attribute pairs that are global attributes, the attributeAccessInterface list from zcl.json needs to be imported into an alternative table, PACKAGE_OPTION.
Given that PACKAGE_OPTION exclusively contains pairs enumerated in zcl.json and does not encompass all attributeAccessInterface pairings, it becomes essential to query both the ATTRIBUTE and PACKAGE_OPTION tables.