fix: Terminal component can leak observers

project-codeflare · Sep 16, 2022 · 1233e37 · 1233e37
1 parent 675c6ad
commit 1233e37
Showing 1 changed file with 1 addition and 0 deletions.
diff --git a/plugins/plugin-codeflare/src/components/Terminal.tsx b/plugins/plugin-codeflare/src/components/Terminal.tsx
@@ -188,6 +188,7 @@ export default class XTerm extends React.PureComponent<Props, State> {
       }
     })
     observer.observe(xtermContainer)
+    this.cleaners.push(() => observer.disconnect())
   }
 
   /**