fix: stop hard-coding default guidebook

This PR allows client plugins to specify the default guidebook in config.d/client "defaultGuidebook", e.g. ``` { "defaultGuidebook": "ml/codeflare" } ```
project-codeflare · Sep 28, 2022 · 4654609 · 4654609
1 parent 4fe63d6
commit 4654609
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/plugins/plugin-client-default/config.d/client.json b/plugins/plugin-client-default/config.d/client.json
@@ -1,3 +1,4 @@
 {
+  "defaultGuidebook": "ml/codeflare",
   "contextRoot": ""
 }
diff --git a/plugins/plugin-madwizard/src/plugin.ts b/plugins/plugin-madwizard/src/plugin.ts
@@ -14,6 +14,7 @@
  * limitations under the License.
  */
 
+import { defaultGuidebook } from "@kui-shell/client/config.d/client.json"
 import { Arguments, ParsedOptions, ReactResponse, Registrar, Tab } from "@kui-shell/core"
 
 export interface Options extends ParsedOptions {
@@ -104,7 +105,7 @@ export function doMadwizard({ readonlyUI = true, task, withFilepath = true, cb,
   return async ({ tab, argvNoOptions, parsedOptions }: Arguments<Options>) => {
     if (withFilepath && !argvNoOptions[1]) {
       // TODO codeflare should not be in plugin-madwizard
-      argvNoOptions.push(process.env.GUIDEBOOK || "ml/codeflare")
+      argvNoOptions.push(process.env.GUIDEBOOK || defaultGuidebook)
     }
 
     if (envFn) {