fix: in ProfileExplorer place profile select in footer

project-codeflare · Oct 11, 2022 · 86ac7c6 · 86ac7c6
1 parent 4d013d7
commit 86ac7c6
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/plugins/plugin-codeflare/src/components/ProfileExplorer.tsx b/plugins/plugin-codeflare/src/components/ProfileExplorer.tsx
@@ -24,6 +24,7 @@ import {
   CardBody,
   CardHeader,
   CardTitle,
+  CardFooter,
   Chip,
   ChipGroup,
   Dropdown,
@@ -299,7 +300,6 @@ class ProfileCard extends React.PureComponent<ProfileCardProps, ProfileCardState
   private actions() {
     return (
       <React.Fragment>
-        {this.title()}
         <Dropdown
           isOpen={this.state.isKebabOpen}
           isPlain
@@ -597,12 +597,13 @@ class ProfileCard extends React.PureComponent<ProfileCardProps, ProfileCardState
 
   public render() {
     return (
-      <Card isLarge>
+      <Card isLarge isPlain isFullHeight>
         <CardHeader>
           <CardTitle>Draft Specification</CardTitle>
           <CardActions hasNoOffset>{this.actions()}</CardActions>
         </CardHeader>
         <CardBody>{this.body()}</CardBody>
+        <CardFooter>{this.title()}</CardFooter>
       </Card>
     )
   }

diff --git a/plugins/plugin-codeflare/src/components/ProfileSelect.tsx b/plugins/plugin-codeflare/src/components/ProfileSelect.tsx
@@ -17,7 +17,7 @@
 import React from "react"
 import prettyMillis from "pretty-ms"
 import { Profiles } from "madwizard"
-import { Select, SelectOption, SelectOptionObject, SelectVariant } from "@patternfly/react-core"
+import { Select, SelectOption, SelectOptionObject } from "@patternfly/react-core"
 
 type Props = {
   selectedProfile?: string
@@ -81,7 +81,8 @@ export default class ProfileSelect extends React.PureComponent<Props, State> {
   public render() {
     return (
       <Select
-        variant={SelectVariant.single}
+        direction="up"
+        variant="single"
         placeholderText="Select a profile"
         aria-label="Profiles selector with description"
         onToggle={this._selectOnToggle}