Skip to content

Commit

Permalink
fix: bumps to pick up improved cancel output and waiting for ray job …
Browse files Browse the repository at this point in the history
…to start
  • Loading branch information
starpit committed Feb 10, 2023
1 parent 2ca946e commit d300e3d
Show file tree
Hide file tree
Showing 3 changed files with 25 additions and 24 deletions.
32 changes: 16 additions & 16 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions plugins/plugin-codeflare/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -30,13 +30,13 @@
"@types/split2": "^3.2.1"
},
"dependencies": {
"@guidebooks/store": "^2.3.2",
"@guidebooks/store": "^2.3.4",
"@logdna/tail-file": "^3.0.1",
"@patternfly/react-charts": "^6.94.18",
"@patternfly/react-core": "^4.276.6",
"asciinema-player": "^3.0.1",
"chokidar": "^3.5.3",
"madwizard": "^5.2.7",
"madwizard": "^5.2.8",
"needle": "^3.2.0",
"open": "^8.4.0",
"pretty-bytes": "^6.0.0",
Expand Down
13 changes: 7 additions & 6 deletions plugins/plugin-codeflare/src/controller/attach.ts
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
* limitations under the License.
*/

import chalk from "chalk"
import Debug from "debug"
import { MadWizardOptions } from "madwizard"
import { Arguments, Capabilities, ParsedOptions } from "@kui-shell/core"
Expand Down Expand Up @@ -61,8 +62,8 @@ export async function attach(
{
appName,
profile,
quiet: true,
interactive: false,
verbose: true,
},
opts
)
Expand All @@ -74,7 +75,7 @@ export async function attach(
try {
const deployOptions = Object.assign({}, options, { name: "log-aggregator-deploy" })
debug("Deploying log aggregator", deployGuidebook, deployOptions)
stderr("Deploying log aggregator...\n")
stderr(chalk.yellow("Deploying log aggregator...\n"))
await guide([appName, "guide", deployGuidebook], undefined, deployOptions)
debug("deploying log aggregator: done")
} catch (err) {
Expand All @@ -83,21 +84,21 @@ export async function attach(
}

debug("attaching to", jobId)
stderr("Attaching to job...\n")
stderr(chalk.yellow("Attaching to job...\n"))
const resp = await guide(
[appName, "guide", startGuidebook],
undefined,
Object.assign({}, options, { name: "log-aggregator-start", clean: false })
)
stderr("Attaching to job done...\n")
stderr(chalk.yellow("Attaching to job done...\n"))

// the logdir that we captured
const logdir = resp && resp.env ? resp.env.LOGDIR_STAGE : undefined
if (logdir) {
debug("successfully attached to", jobId, logdir)
stderr("Successfully attached to job")
stderr(chalk.green("Successfully attached to job\n"))
} else {
stderr("Error in attach to job (logdir not found)")
stderr(chalk.red("Error in attach to job (logdir not found)\n"))
}

return {
Expand Down

0 comments on commit d300e3d

Please sign in to comment.