fix: do not use font-weight: 500 for "simplistic" selects, those with…

… no item descriptions
project-codeflare · Nov 21, 2022 · dc2c137 · dc2c137
1 parent c133c93
commit dc2c137
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/plugins/plugin-codeflare/src/components/Ask.tsx b/plugins/plugin-codeflare/src/components/Ask.tsx
@@ -300,10 +300,15 @@ export default class AskUI extends React.PureComponent<Props, State> {
       children: mkOptions(),
     }
 
+    // is every message the same as the title?
+    const isSimplistic = ask.prompt.choices.every(
+      (_) => _.name === stripAnsi(_.message).replace("  ◄ you selected this last time", "")
+    )
+
     return (
       <React.Fragment>
         <span id={titleId} hidden />
-        {this.card(ask, <Select {...props} />)}
+        {this.card(ask, <Select {...props} data-is-simplistic={isSimplistic || undefined} />)}
       </React.Fragment>
     )
   }

diff --git a/plugins/plugin-codeflare/web/scss/components/Ask/_index.scss b/plugins/plugin-codeflare/web/scss/components/Ask/_index.scss
@@ -53,8 +53,10 @@ $max-width: 50rem;
     max-width: $max-width;
   }
 
-  .pf-c-select__menu-item-main {
+  .pf-c-select__menu:not([data-is-simplistic]) .pf-c-select__menu-item-main {
     font-weight: 500;
+  }
+  .pf-c-select__menu-item-main {
     white-space: normal;
   }
 }